Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RB-6 Feature/storybook #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/CODEOWNERS

This file was deleted.

27 changes: 0 additions & 27 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

17 changes: 0 additions & 17 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

26 changes: 6 additions & 20 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,9 @@
## React Boilerplate
`Feature Description`: Insert here a brief description

Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/CONTRIBUTING.md)
to make the process easy and effective for everyone involved.
`Task related`: Insert here an Asana's URL

**Please open an issue** before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Pay attention to:

Before opening a pull request, please ensure:

- [ ] You have followed our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/CONTRIBUTING.md)
- [ ] Double-check your branch is based on `dev` and targets `dev`
- [ ] Pull request has tests (we are going for 100% coverage!)
- [ ] Code is well-commented, linted and follows project conventions
- [ ] Documentation is updated (if necessary)
- [ ] Internal code generators and templates are updated (if necessary)
- [ ] Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

**IMPORTANT**: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the [MIT License](https://github.com/react-boilerplate/react-boilerplate/blob/master/LICENSE.md).
- Add at least one reviewer
- Assign yourself to the PR
- In case the PR isn't ready for review, change your PR as a Draft (`Create Pull Request` has a dropdown to change it)
14 changes: 0 additions & 14 deletions .github/issue-close-app.yml

This file was deleted.

29 changes: 0 additions & 29 deletions .github/lock.yml

This file was deleted.

10 changes: 10 additions & 0 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module.exports = {
"stories": [
"../stories/**/*.stories.mdx",
"../stories/**/*.stories.@(js|jsx|ts|tsx)"
],
"addons": [
"@storybook/addon-links",
"@storybook/addon-essentials"
]
}
4 changes: 4 additions & 0 deletions .storybook/preview.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

export const parameters = {
actions: { argTypesRegex: "^on[A-Z].*" },
}
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@

4 changes: 2 additions & 2 deletions app/containers/HomePage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ export default function HomePage() {
<LoadingOverlay show={loading} />
<Grid container spacing={2}>
<Grid item xs={12}>
<h1>This is the HomePage container!</h1>
<h1>Projeto MonitorAR</h1>
</Grid>
<Grid item xs={12}>
<LoadingButton variant="outlined" onClick={handleDummyLoader}>
<span>
Click here to dispatch <b>dummyRequest</b> action!
Clique aqui para disparar uma <b>dummyRequest</b> ação!
</span>
</LoadingButton>
</Grid>
Expand Down
4 changes: 2 additions & 2 deletions app/containers/HomePage/saga.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import { triggerDummyLoading } from './actions';

export function* triggerDummyLoadingSaga() {
yield put(triggerDummyLoading(true));
yield delay(500);
yield delay(5000);
yield put(triggerDummyLoading(false));
}

export default function* saga() {
yield takeLatest(ActionTypes.DUMMY_REQUEST, triggerDummyLoadingSaga);
}
}
Loading