Property FinalizationRegistry doesn't exist.

[lifeissummertime]

Intended outcome:
Should not occur this error on ios react native

Actual outcome:

How to reproduce the issue: I tried to apply Mobx on an expo created react natice project. I don't think the environment has FinalizationRegistry.

Versions mobx-react-lite 3.4.1

"expo": "~48.0.5",
"expo-font": "~11.1.1",
"expo-linking": "~4.0.1",
"expo-splash-screen": "~0.18.1",
"expo-status-bar": "~1.4.4",
"expo-system-ui": "~2.2.1",
"expo-web-browser": "~12.1.1",
"mobx": "^6.8.0",
"mobx-react": "^7.6.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.71.3",
"react-native-screens": "~3.20.0",

Suggestion Maybe it works if in this way typeof FinalizationRegistry !== 'undefined'

[kubk]

Hi, I am unable to reproduce the issue here: https://snack.expo.dev/vEF39Ohnb

The mobx-react-lite is 3.4.1 as you mentioned. It looks like your bundler doesn't use a bundled Mobx version. Its locations:

• node_modules/mobx/dist/mobx.cjs.development.js (CommonJS dev)
• node_modules/mobx/dist/mobx.cjs.production.min.js (CommonJS prod)
• node_modules/mobx/dist/mobx.esm.development.js (ES6 dev)
• node_modules/mobx/dist/mobx.esm.production.js (ES6 prod)

[urugator]

Suggestion Maybe it works if in this way typeof FinalizationRegistry !== undefined

PR welcome

[lifeissummertime]

Hi, I am unable to reproduce the issue here: https://snack.expo.dev/vEF39Ohnb

The mobx-react-lite is 3.4.1 as you mentioned. It looks like your bundler doesn't use a bundled Mobx version. Its locations:

• node_modules/mobx/dist/mobx.cjs.development.js (CommonJS dev)
• node_modules/mobx/dist/mobx.cjs.production.min.js (CommonJS prod)
• node_modules/mobx/dist/mobx.esm.development.js (ES6 dev)
• node_modules/mobx/dist/mobx.esm.production.js (ES6 prod)

Sorry for the late reply. This issue happened only on my real iphone device. It works well on web. I downgraded to 3.4.0 and it worked well.

[mweststrate]

I think the fix would still be correct though, the current implementation would throw in an environment where it isn't available

…

On Sun, 5 Mar 2023, 12:53 Summer Time, ***@***.***> wrote: Hi, I am unable to reproduce the issue here: https://snack.expo.dev/vEF39Ohnb The mobx-react-lite is 3.4.1 as you mentioned. It looks like your bundler doesn't use a bundled Mobx version. Its locations: - node_modules/mobx/dist/mobx.cjs.development.js (CommonJS dev) - node_modules/mobx/dist/mobx.cjs.production.min.js (CommonJS prod) - node_modules/mobx/dist/mobx.esm.development.js (ES6 dev) - node_modules/mobx/dist/mobx.esm.production.js (ES6 prod) Sorry for the late reply. This issue happened only on my real iphone device. It works well on web. I downgraded to 3.4.0 and it worked well. — Reply to this email directly, view it on GitHub <#3643 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBCDFKSLB65AGJZHTPLW2R5CFANCNFSM6AAAAAAVPS22TA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[lifeissummertime]

I tried https://snack.expo.dev/vEF39Ohnb , and it worked well. My case is on debug mode, and the source code pointed to /node_modules/mobx-react-lite/es/utils/UniversalFinalizationRegistry.js

I searched the package, and there are only two files. Quite strange, it only happens in debug mode?

[lifeissummertime]

I temporarily modified the code and it worked well.

[lifeissummertime]

Suggestion Maybe it works if in this way typeof FinalizationRegistry !== undefined

PR welcome

Sorry, undefined may need to be quoted typeof FinalizationRegistry !== 'undefined'