add warn for extending builtins

[iChenLei]

Code change checklist

• Added/updated unit tests
• Updated /docs. For new functionality, at least API.md should be updated
• Verified that there is no significant performance drop (npm run perf)

PR Background

issue -> fix #2765
Add friendly warn for extending builtins action.
Current 👇

After 👇

[changeset-bot]

🦋 Changeset detected

Latest commit: 781de7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mobx	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[urugator]

Thanks for the PR, but please try to handle it like this:

mobx/packages/mobx/src/types/observableobject.ts

Line 648 in ddf9978

if (hasProp(target, $mobx)) return target

if (hasProp(target, $mobx)) {
  if (__DEV__ && !(getAdministration(target) instanceof ObservableObjectAdministration)) {
     // Something like
     die(`Cannot convert '${getDebugName(target)}' into observable object: The target is already observable of different type. Extending builtins is not supported.`)
  }
  return target
}

That should cover other unsupported cases like makeAutoObservable/extendObservable(boxedObservable|observableArray|observableMap|observableSet) etc
And please add tests for these other types.
EDITED

[iChenLei]

@urugator Yes, sir. 😃

[iChenLei]

@urugator Hi, sir. Did we need test all types? I found that only observableMap and observableSet are export from mobx npm package.

packages/mobx/src/mobx.ts

extendObservable

https://mobx.js.org/api.html#extendobservable

May be it's only use for function/object ? Any suggestion to test it ?

makeAutoObservable

// https://github.com/mobxjs/mobx/blob/main/packages/mobx/src/api/makeObservable.ts#L50-L55
if (__DEV__) {
    if (!isPlainObject(target) && !isPlainObject(Object.getPrototypeOf(target)))
        👇  // user can't extending builtin, so don't need check more
        die(`'makeAutoObservable' can only be used for classes that don't have a superclass`) 
    if (isObservableObject(target))
        die(`makeAutoObservable can only be used on objects not already made observable`)
}

[urugator]

Did we need test all types?

It's not about preventing extend Builtin.
It's about inability to pass observable of different type than object to extendObservable/makeObservable/makeAutoObservable.
So makeObservable(observable([])), extendObservable(observable.box()) etc should fail (not neccessarily with the same error, but they must not pass).
It doesn't have to happen inside constructor when extending, thats just a special case.
Is it clear?

[mweststrate]

Looking good, thanks for making this change!