-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: A slight revamp of the README, wording, and clearer links #3458
Conversation
🦋 Changeset detectedLatest commit: 63f1324 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…d to makeObservable. Fixing the spelling of "overriden"→"overridden".
First of all, thank you for your initiative and will to improve things, it's appreciated. The issue is that PR is too big and it'd have been merged more quickly if it had been split into different PRs. But we may continue as is, it'll just take more time |
…Sponsors in the Readme
All changes sound good to me, thanks for making this effort! The only one I have a beef with is this one:
What mobx does is not strictly functional reactive programming, and just RP itself is very wide and vague as well. It's the transparent nature that make MobX quite stands out, so I think it is fine to keep this term, even when it is new for most people and has little prior art, it kinda covers the growing niche we're in better than the others. Checking Svelte and Solid, they just call it "Reactive", without any additional flavours :-P |
I have reverted back to the original wording. I did originally have a hard time finding information about the term so perhaps either of the following would work:
|
Both work for me, 2nd is slightly cooleer I think |
I see that CI is failing, probably due to outdated snapshots. I'll fix it once I am available |
@egilll Is option Allow edits from maintainers enabled for this PR? Could you enable it? |
@egilll Thank you so much 👍 |
Hi. This pull request changes a handful of things which I found to be confusing when reading this otherwise excellent documentation. I apologize if this PR is too bold — do of course feel free to close this PR should you disagree with these changes.
The changes are:
I believe it is better to let readers know what the project is about before showing a long list of sponsors, so I've moved the introduction above the list of sponsors.