Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make return value of reportObserved match invoke of onBecomeObserved #3566

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Nov 6, 2022

This fixes #3563.

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2022

🦋 Changeset detected

Latest commit: 01a6174

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@urugator
Copy link
Collaborator

urugator commented Nov 7, 2022

LGTM, thank you!

@urugator urugator merged commit fe25cfe into mobxjs:main Nov 7, 2022
@github-actions github-actions bot mentioned this pull request Nov 7, 2022
@upsuper upsuper deleted the report-observed-batch branch November 7, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value of Atom.reportObserved is inconsistent with whether onBecomeObserved is called
2 participants