Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated information from mobx-react README #3577

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Conversation

kubk
Copy link
Collaborator

@kubk kubk commented Nov 16, 2022

Since we only support mobx-react 7+ I've removed confusing information from the README. I've removed the comparison table completely because there is nothing to choose from. Only the latest version is maintained.

@kubk kubk requested a review from urugator November 16, 2022 15:32
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

⚠️ No Changeset found

Latest commit: 1a591cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@urugator
Copy link
Collaborator

urugator commented Nov 16, 2022

Thank you for the PR. I think the version table can still prove useful/relevant, there seems to be quite a few users still using mobx 5 or even 4. Perhaps just change the title to "Compatibility matrix" and add something like:
"Only the latest version is actively maintained. If you're missing a fix or a feature in older version, consider upgrading or using patch-package"

@kubk
Copy link
Collaborator Author

kubk commented Nov 17, 2022

@urugator Agreed, done 👍

@kubk
Copy link
Collaborator Author

kubk commented Nov 23, 2022

Hi @urugator

Since it's just a README change I think we can merge it without waiting for CI. Thanks

@urugator
Copy link
Collaborator

Since it's just a README change I think we can merge it without waiting for CI. Thanks

I don't have permissions to merge unless it's all green.

@mweststrate mweststrate merged commit 646ee57 into main Nov 23, 2022
@mweststrate
Copy link
Member

merge overriden, I see if I can uninstall netlify, I suspended it, not sure why taht isn't enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants