Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urugator fix 3671 #3718

Merged
merged 19 commits into from Jul 12, 2023
Merged

Urugator fix 3671 #3718

merged 19 commits into from Jul 12, 2023

Conversation

mweststrate
Copy link
Member

See #3673

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2023

🦋 Changeset detected

Latest commit: 46d741a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mobx-react-lite Patch
mobx-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@urugator
Copy link
Collaborator

urugator commented Jul 10, 2023

Found suggestions to run a microtask before calling the gc(), like:

test('cleaned', async () => {
  const w = weak();
  await new Promise(resolve => setTimeout(resolve, 0));
  global.gc();
  expect(w.deref()).toEqual(null);
});

@mweststrate mweststrate merged commit 473cb3f into main Jul 12, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants