-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin-mobx): configurable default autofix annotation for makeObservable #3881
Conversation
🦋 Changeset detectedLatest commit: 074c373 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Would you mind creating a PR that just runs prettier so we would merge it first? If not, it's completely fine, just pinpoint me to the changed lines, I assume it should be just 9, 80, 85. |
I can do that -- if it needs to be applied to the whole project though it looks like about 35 files are going to be changed. For now I'll push some commits in a bit that separate out the initial prettier write step and the changes I made to make it more obvious. |
cd07611
to
074c373
Compare
See 1e99618 for the extent of actual changes. |
With additional changes LGTM, thanks for adding this! |
Adds an option for the
mobx/exhaustive-make-observable
eslint rule to configure whether fields are annotated withtrue
orfalse
with the autofixer.This option defaults to
true
if not present or an invalid value is received to maintain existing behavior.Code change checklist
/docs
. For new functionality, at leastAPI.md
should be updatedyarn mobx test:performance
)Note: It looks like some formatting rules have changed since the last time this file was touched so there's quite a lot of changes.
Closes #3876