-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3908: mobx/missing-observer rule false positive with forwardRef #3909
Conversation
🦋 Changeset detectedLatest commit: d8d44e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -74,5 +74,6 @@ | |||
"hooks": { | |||
"pre-commit": "pretty-quick --staged" | |||
} | |||
} | |||
}, | |||
"packageManager": "yarn@1.22.21+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this configuration? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corepack
can't live without it unless you set env variable COREPACK_ENABLE_AUTO_PIN
to 0
, which is quite inconvinient to do. But now when thinking about it, yarn
maybe also checks this field, so it may cause issues to non-corepack users, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, there is a SKIP_YARN_COREPACK_CHECK
env var for yarn
, but this is equally bad as the need to set COREPACK_ENABLE_AUTO_PIN
. Feel free to revert the change if it's causing problems, unless you know of a better solution of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #3908