-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Examples #69
Update Examples #69
Conversation
- upgrade to using babel - upgrade deps
No problem, I'll look into it! |
Pushed some changes, it seems that the typescript generation wasn't really kept up to date.
Fixed the following examples:
Ideally I would want to verify that the other examples are still working, but probably I won't have much time in the coming week, so it might be a good idea to merge this PR already after review, as it fixes quite a bunch of open issues (and makes mst-gql usable in TS again) |
@mweststrate I'm taking a look at this now, I'll see if I can't get all the examples running! |
- not all examples run a server. - treat example `README.md` as source of truth for that example
ok, I fixed example 3 and updates some docs. I'll see if I can't get 4 and 5 running as well. |
ok, I need to stop for now, but I got everything but example 4 running. If anyone else has experience with Apollo I'd love help getting it going as I've never used it! |
I might go ahead and merge this and open a new issue to fix example 4. @elie222 thoughts? |
Sounds like a plan!
Op za 3 aug. 2019 23:30 schreef Chris Drackett <notifications@github.com>:
… I might go ahead and merge this and open a new issue to fix example 4.
@elie222 <https://github.com/elie222> thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69?email_source=notifications&email_token=AAN4NBGEVZ2HATFA6WSQ7KDQCX2GRA5CNFSM4IISW7HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PWDMY#issuecomment-517956019>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN4NBFECRLHNXWXN3HE66LQCX2GRANCNFSM4IISW7HA>
.
|
Will take a look at example 4 tomorrow. Familiar with Apollo |
@mweststrate when using this in my own project I'm seeing a typescript error that I don't see in the examples:
any thoughts on what might be causing this? |
As part of this PR I updated example 1 in the following ways:
I've never run the examples myself and wasn't having much luck getting example 1 to run. I switched over to using babel-typescript so that our current typescript errors don't break the build. I got past that part and the page now shows up in the browser, but with errors.
At this point I feel like I might be missing steps, and think my errors probably have something to do with conflicting react versions between the base
node_modules
and thenode_modules
in example 1. (Uncaught Invariant Violation: Rendered fewer hooks than expected. This may be caused by an accidental early return statement.
)I don't have any more time right not to spend on it but figured it can't hurt to put my work so far up.
closes #67