Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCOW/tests: revisit skipped integration tests to run on Windows where applicable #4485

Open
profnandaa opened this issue Dec 14, 2023 · 4 comments
Open

WCOW/tests: revisit skipped integration tests to run on Windows where applicable #4485

profnandaa opened this issue Dec 14, 2023 · 4 comments
Assignees
@profnandaa
Labels
area/windows area/windows-wcow

Comments

@profnandaa
Copy link
Collaborator

profnandaa commented Dec 14, 2023 •
edited
Loading

I'm opening this issue as a tracker for the explicitly skipped integration tests on Windows. Some should be skipped by design but others need to be enabled on Windows too.

Here is the list (might keep growing as new tests come in):

Script 
  $ grep -r -B 1 ".SkipOnPlatform(" | grep -v "^--" | grep -v "integration.SkipOn" |  sed 's/-/ /' | sed 's/^/- [ ] /'

/client:

  • client/build_test.go testClientGatewayEmptyImageExec
  • client/client_test.go testCacheExportCacheKeyLoop
  • client/client_test.go testBridgeNetworkingDNSNoRootless
  • client/client_test.go testExportedImageLabels
  • client/client_test.go testExportBusyboxLocal
  • client/client_test.go testHostnameLookup
  • client/client_test.go testHostnameSpecifying
  • client/client_test.go testStdinClosed
  • client/client_test.go testSSHMount
  • client/client_test.go testExtraHosts
  • client/client_test.go testShmSize
  • client/client_test.go testUlimit
  • client/client_test.go testNetworkMode
  • client/client_test.go testSecurityMode
  • client/client_test.go testSecurityModeSysfs
  • client/client_test.go testSecurityModeErrors
  • client/client_test.go testSecretMounts
  • client/client_test.go testSecretEnv
  • client/client_test.go testBuildHTTPSource
  • client/client_test.go testSourceDateEpochImageExporter
  • client/client_test.go testBuildExportWithForeignLayer
  • client/client_test.go testBuildExportZstd
  • client/client_test.go testPullZstdImage
  • client/client_test.go testZstdLocalCacheExport
  • client/client_test.go testCacheExportIgnoreError
  • client/client_test.go testBasicS3CacheImportExport
  • client/client_test.go testBasicAzblobCacheImportExport
  • client/client_test.go testSnapshotWithMultipleBlobs
  • client/client_test.go testExportLocalNoPlatformSplit
  • client/client_test.go testMoveParentDir
  • client/client_test.go testSchema1Image
  • client/client_test.go testMountWithNoSource
  • client/client_test.go testReadonlyRootFS
  • client/client_test.go testRmSymlink
  • client/client_test.go testProxyEnv
  • client/client_test.go testParallelLocalBuilds
  • client/client_test.go testMultipleCacheExports
  • client/client_test.go testMountStubsDirectory
  • client/client_test.go testMountStubsTimestamp
  • client/client_test.go testLLBMountPerformance

/cmd/buildctl:

  • cmd/buildctl/buildctl_test.go testUsage
  • cmd/buildctl/build_test.go testBuildWithLocalFiles
  • cmd/buildctl/build_test.go testBuildLocalExporter
  • cmd/buildctl/build_test.go testBuildContainerdExporter
  • cmd/buildctl/build_test.go testBuildMetadataFile
  • cmd/buildctl/diskusage_test.go testDiskUsage
  • cmd/buildctl/prune_test.go testPrune

/frontend:

  • frontend/dockerfile/dockerfile_addchecksum_test.go testAddChecksum
  • frontend/dockerfile/dockerfile_addgit_test.go testAddGit
  • frontend/dockerfile/dockerfile_heredoc_test.go testCopyHeredoc
  • frontend/dockerfile/dockerfile_heredoc_test.go testCopyHeredocSpecialSymbols
  • frontend/dockerfile/dockerfile_heredoc_test.go testRunBasicHeredoc
  • frontend/dockerfile/dockerfile_heredoc_test.go testRunFakeHeredoc
  • frontend/dockerfile/dockerfile_heredoc_test.go testRunShebangHeredoc
  • frontend/dockerfile/dockerfile_heredoc_test.go testRunComplexHeredoc
  • frontend/dockerfile/dockerfile_heredoc_test.go testHeredocIndent
  • frontend/dockerfile/dockerfile_heredoc_test.go testHeredocVarSubstitution
  • frontend/dockerfile/dockerfile_heredoc_test.go testOnBuildHeredoc
  • frontend/dockerfile/dockerfile_mount_test.go testMountContext
  • frontend/dockerfile/dockerfile_mount_test.go testMountTmpfs
  • frontend/dockerfile/dockerfile_mount_test.go testMountInvalid
  • frontend/dockerfile/dockerfile_mount_test.go testMountRWCache
  • frontend/dockerfile/dockerfile_mount_test.go testCacheMountUser
  • frontend/dockerfile/dockerfile_mount_test.go testCacheMountDefaultID
  • frontend/dockerfile/dockerfile_mount_test.go testMountEnvVar
  • frontend/dockerfile/dockerfile_mount_test.go testMountArg
  • frontend/dockerfile/dockerfile_mount_test.go testMountEnvAcrossStages
  • frontend/dockerfile/dockerfile_mount_test.go testMountMetaArg
  • frontend/dockerfile/dockerfile_mount_test.go testMountFromError
  • frontend/dockerfile/dockerfile_mount_test.go testMountTmpfsSize
  • frontend/dockerfile/dockerfile_mount_test.go testMountDuplicate
  • frontend/dockerfile/dockerfile_outline_test.go testOutlineArgs
  • frontend/dockerfile/dockerfile_outline_test.go testOutlineSecrets
  • frontend/dockerfile/dockerfile_outline_test.go testOutlineDescribeDefinition
  • frontend/dockerfile/dockerfile_provenance_test.go testProvenanceAttestation
  • frontend/dockerfile/dockerfile_provenance_test.go testGitProvenanceAttestation
  • frontend/dockerfile/dockerfile_provenance_test.go testMultiPlatformProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testClientFrontendProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testClientLLBProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testSecretSSHProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testOCILayoutProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testNilProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testDuplicatePlatformProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testDockerIgnoreMissingProvenance
  • frontend/dockerfile/dockerfile_provenance_test.go testFrontendDeduplicateSources
  • frontend/dockerfile/dockerfile_provenance_test.go testDuplicateLayersProvenance
  • frontend/dockerfile/dockerfile_runnetwork_test.go testRunGlobalNetwork
  • frontend/dockerfile/dockerfile_secrets_test.go testSecretFileParams
  • frontend/dockerfile/dockerfile_secrets_test.go testSecretRequiredWithoutValue
  • frontend/dockerfile/dockerfile_ssh_test.go testSSHSocketParams
  • frontend/dockerfile/dockerfile_ssh_test.go testSSHFileDescriptorsClosed
  • frontend/dockerfile/dockerfile_targets_test.go testTargetsList
  • frontend/dockerfile/dockerfile_targets_test.go testTargetsDescribeDefinition
  • frontend/dockerfile/dockerfile_test.go testDefaultEnvWithArgs
  • frontend/dockerfile/dockerfile_test.go testEnvEmptyFormatting
  • frontend/dockerfile/dockerfile_test.go testDockerignoreOverride
  • frontend/dockerfile/dockerfile_test.go testEmptyDestDir
  • frontend/dockerfile/dockerfile_test.go testExportCacheLoop
  • frontend/dockerfile/dockerfile_test.go testTarExporter
  • frontend/dockerfile/dockerfile_test.go testWorkdirCreatesDir
  • frontend/dockerfile/dockerfile_test.go testCacheReleased
  • frontend/dockerfile/dockerfile_test.go testSymlinkedDockerfile
  • frontend/dockerfile/dockerfile_test.go testCopyChownExistingDir
  • frontend/dockerfile/dockerfile_test.go testCopyWildcardCache
  • frontend/dockerfile/dockerfile_test.go testEmptyWildcard
  • frontend/dockerfile/dockerfile_test.go testWorkdirUser
  • frontend/dockerfile/dockerfile_test.go testWorkdirCopyIgnoreRelative
  • frontend/dockerfile/dockerfile_test.go testWorkdirExists
  • frontend/dockerfile/dockerfile_test.go testCopyChownCreateDest
  • frontend/dockerfile/dockerfile_test.go testCopyThroughSymlinkContext
  • frontend/dockerfile/dockerfile_test.go testCopyThroughSymlinkMultiStage
  • frontend/dockerfile/dockerfile_test.go testCopySocket
  • frontend/dockerfile/dockerfile_test.go testIgnoreEntrypoint
  • frontend/dockerfile/dockerfile_test.go testQuotedMetaArgs
  • frontend/dockerfile/dockerfile_test.go testMultiArgs
  • frontend/dockerfile/dockerfile_test.go testDefaultShellAndPath
  • frontend/dockerfile/dockerfile_test.go testExportMultiPlatform
  • frontend/dockerfile/dockerfile_test.go testContextChangeDirToFile
  • frontend/dockerfile/dockerfile_test.go testNoSnapshotLeak
  • frontend/dockerfile/dockerfile_test.go testCopyFollowAllSymlinks
  • frontend/dockerfile/dockerfile_test.go testCopySymlinks
  • frontend/dockerfile/dockerfile_test.go testHTTPDockerfile
  • frontend/dockerfile/dockerfile_test.go testCmdShell
  • frontend/dockerfile/dockerfile_test.go testPullScratch
  • frontend/dockerfile/dockerfile_test.go testGlobalArg
  • frontend/dockerfile/dockerfile_test.go testDockerfileDirs
  • frontend/dockerfile/dockerfile_test.go testDockerfileInvalidCommand
  • frontend/dockerfile/dockerfile_test.go testDockerfileInvalidInstruction
  • frontend/dockerfile/dockerfile_test.go testDockerfileADDFromURL
  • frontend/dockerfile/dockerfile_test.go testDockerfileAddArchive
  • frontend/dockerfile/dockerfile_test.go testDockerfileAddArchiveWildcard
  • frontend/dockerfile/dockerfile_test.go testDockerfileAddChownExpand
  • frontend/dockerfile/dockerfile_test.go testSymlinkDestination
  • frontend/dockerfile/dockerfile_test.go testDockerfileScratchConfig
  • frontend/dockerfile/dockerfile_test.go testExposeExpansion
  • frontend/dockerfile/dockerfile_test.go testDockerignore
  • frontend/dockerfile/dockerfile_test.go testDockerignoreInvalid
  • frontend/dockerfile/dockerfile_test.go testDockerfileLowercase
  • frontend/dockerfile/dockerfile_test.go testExportedHistory
  • frontend/dockerfile/dockerfile_test.go testUser
  • frontend/dockerfile/dockerfile_test.go testUserAdditionalGids
  • frontend/dockerfile/dockerfile_test.go testCopyChmod
  • frontend/dockerfile/dockerfile_test.go testCopyOverrideFiles
  • frontend/dockerfile/dockerfile_test.go testCopyVarSubstitution
  • frontend/dockerfile/dockerfile_test.go testCopyWildcards
  • frontend/dockerfile/dockerfile_test.go testCopyRelative
  • frontend/dockerfile/dockerfile_test.go testAddURLChmod
  • frontend/dockerfile/dockerfile_test.go testDockerfileFromGit
  • frontend/dockerfile/dockerfile_test.go testDockerfileFromHTTP
  • frontend/dockerfile/dockerfile_test.go testMultiStageImplicitFrom
  • frontend/dockerfile/dockerfile_test.go testMultiStageCaseInsensitive
  • frontend/dockerfile/dockerfile_test.go testLabels
  • frontend/dockerfile/dockerfile_test.go testWildcardRenameCache
  • frontend/dockerfile/dockerfile_test.go testOnBuildCleared
  • frontend/dockerfile/dockerfile_test.go testCacheMultiPlatformImportExport
  • frontend/dockerfile/dockerfile_test.go testImageManifestCacheImportExport
  • frontend/dockerfile/dockerfile_test.go testCacheImportExport
  • frontend/dockerfile/dockerfile_test.go testReproducibleIDs
  • frontend/dockerfile/dockerfile_test.go testImportExportReproducibleIDs
  • frontend/dockerfile/dockerfile_test.go testNoCache
  • frontend/dockerfile/dockerfile_test.go testPlatformArgsImplicit
  • frontend/dockerfile/dockerfile_test.go testPlatformArgsExplicit
  • frontend/dockerfile/dockerfile_test.go testBuiltinArgs
  • frontend/dockerfile/dockerfile_test.go testTarContext
  • frontend/dockerfile/dockerfile_test.go testTarContextExternalDockerfile
  • frontend/dockerfile/dockerfile_test.go testFrontendUseForwardedSolveResults
  • frontend/dockerfile/dockerfile_test.go testFrontendInputs
  • frontend/dockerfile/dockerfile_test.go testFrontendSubrequests
  • frontend/dockerfile/dockerfile_test.go testDockefileCheckHostname
  • frontend/dockerfile/dockerfile_test.go testShmSize
  • frontend/dockerfile/dockerfile_test.go testUlimit
  • frontend/dockerfile/dockerfile_test.go testCgroupParent
  • frontend/dockerfile/dockerfile_test.go testNamedImageContext
  • frontend/dockerfile/dockerfile_test.go testNamedImageContextPlatform
  • frontend/dockerfile/dockerfile_test.go testNamedImageContextTimestamps
  • frontend/dockerfile/dockerfile_test.go testNamedImageContextScratch
  • frontend/dockerfile/dockerfile_test.go testNamedLocalContext
  • frontend/dockerfile/dockerfile_test.go testNamedOCILayoutContext
  • frontend/dockerfile/dockerfile_test.go testNamedOCILayoutContextExport
  • frontend/dockerfile/dockerfile_test.go testNamedInputContext
  • frontend/dockerfile/dockerfile_test.go testNamedMultiplatformInputContext
  • frontend/dockerfile/dockerfile_test.go testNamedFilteredContext
  • frontend/dockerfile/dockerfile_test.go testSourceDateEpochWithoutExporter
  • frontend/dockerfile/dockerfile_test.go testSBOMScannerImage
  • frontend/dockerfile/dockerfile_test.go testSBOMScannerArgs
  • frontend/dockerfile/dockerfile_test.go testMultiPlatformWarnings
  • frontend/dockerfile/dockerfile_test.go testReproSourceDateEpoch
  • frontend/dockerfile/dockerfile_test.go testCopyUnicodePath
  • frontend/dockerfile/errors_test.go testErrorsSourceMap
  • frontend/frontend_test.go testRefReadFile **
  • frontend/frontend_test.go testRefReadDir **
  • frontend/frontend_test.go testRefStatFile **
  • frontend/frontend_test.go testRefEvaluate **

/solver:

  • solver/jobs_test.go testParallelism

Previously Skipped Tests:

  • cache/contenthash/checksum_test.go createRef
  • cache/manager_test.go TestSnapshotExtract
  • cache/manager_test.go TestExtractOnMutable
  • cache/manager_test.go TestMergeOp
  • cache/manager_test.go TestDiffOp
  • source/git/source_test.go testRepeatedFetch
  • source/git/source_test.go testFetchBySHA
  • source/git/source_test.go testFetchByTag
  • source/git/source_test.go testMultipleRepos
  • source/git/source_test.go TestCredentialRedaction
  • source/git/source_test.go testSubdir
  • source/http/source_test.go TestHTTPSource
  • source/http/source_test.go TestHTTPChecksum
  • source/http/source_test.go TestHTTPDefaultName

Misc. Tasks
@profnandaa profnandaa self-assigned this Dec 14, 2023
@profnandaa profnandaa mentioned this issue Dec 14, 2023
Merged
@profnandaa
Copy link
Collaborator Author

/cc. @gabriel-samfira

@tonistiigi
Copy link
Member

@profnandaa Look at some of these cases as well https://github.com/moby/buildkit/blame/master/cache/manager_test.go#L577 in cache and source packages. Can some of these skips be removed now?

@profnandaa
Copy link
Collaborator Author

profnandaa commented Dec 14, 2023 •
edited
Loading

@tonistiigi -- sure, let me rake through the previously skipped cases too, I'd missed that.

@profnandaa
Copy link
Collaborator Author

Found 13 tests that were previously skipped, I've added them at the end of the list.

profnandaa added a commit to profnandaa/buildkit that referenced this issue Dec 18, 2023
@profnandaa
tests: enable previously skipped tests
18d40f0 
This enables 3 tests that had been previously skipped
due to the lack of Windows support initially.

The remaining ones in that group, see moby#4485, will need
some code modifications to be enabled.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@profnandaa profnandaa mentioned this issue Dec 18, 2023
Merged
14 tasks
@profnandaa profnandaa mentioned this issue Jan 8, 2024
Open
azr pushed a commit to azr/buildkit that referenced this issue May 7, 2024
@profnandaa @azr
tests: enable previously skipped tests
5bdddef 
This enables 3 tests that had been previously skipped
due to the lack of Windows support initially.

The remaining ones in that group, see moby#4485, will need
some code modifications to be enabled.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jun 12, 2024
@profnandaa
wip: enabling integration tests on windows
a2b6def 
Depends on moby#4994
Partial fix for moby#4485

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Signed-off-by: Anthony Nandaa (from Dev Box) <profnandaa@gmail.com>
@profnandaa profnandaa mentioned this issue Jun 12, 2024
Merged
3 tasks
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jun 13, 2024
@profnandaa
wip: enabling integration tests on windows
6f74e87 
Depends on moby#4994
Partial fix for moby#4485

Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Signed-off-by: Anthony Nandaa (from Dev Box) <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jun 13, 2024
@profnandaa
wip: enabling integration tests on windows
ee99673 
Depends on moby#4994
Partial fix for moby#4485

Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 2, 2024
@profnandaa
test: enabling integration tests on windows
12e3fe7 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 2, 2024
@profnandaa
test: enabling integration tests on windows
a6199fc 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 2, 2024
@profnandaa
test: enabling integration tests on windows
ab5e048 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 8, 2024
@profnandaa
test: enabling integration tests on windows
562278d 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 8, 2024
@profnandaa
test: enabling integration tests on windows
4e57419 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 10, 2024
@profnandaa
test: enabling integration tests on windows
a18aa98 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 10, 2024
@profnandaa
test: enabling integration tests on windows
9e4329a 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 10, 2024
@profnandaa
test: enabling integration tests on windows
b741501 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 11, 2024
@profnandaa
test: enabling integration tests on windows
c590525 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Jul 12, 2024
@profnandaa
test: enabling integration tests on windows
b4108e2 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 15, 2024
@profnandaa
test: enabling integration tests on windows
71ee2e1 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 15, 2024
@profnandaa
test: enabling integration tests on windows
dbce339 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 16, 2024
@profnandaa
test: enabling integration tests on windows
ca358be 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Jul 16, 2024
@profnandaa
test: enabling integration tests on windows
e15c290 
Starting off with this one as a POC on the approach, before we
proceed to complete the rest under `/frontend/dockerfile`.

Tests covered so far:

- [x] `/frontend/dockerfile: testEnvEmptyFormatting`
- [x] `/frontend/dockerfile: testDockerignoreOverride`
- [x] `/frontend/dockerfile: caseEmptyDestDir`

Starts addressing moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 25, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
8e38ee4 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 25, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
841c0ca 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 25, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
830a460 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 26, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
43e21f6 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 26, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
df56a39 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 26, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
b8d3322 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 26, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
8f9ec56 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 26, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
cb75f16 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Sep 26, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
9fa7523 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 1, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
99d0eaa 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 1, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
07c7c08 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 2, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
3b780c4 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 2, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
70ccac5 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 2, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
c8e79f9 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
@danielGithinji danielGithinji mentioned this issue Oct 2, 2024
Open
7 tasks
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 7, 2024
@crazy-max @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
53a5fa3 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 8, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
fbf440e 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 8, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
382ecfb 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 23, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
d28f4b1 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 23, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
6cd2d33 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 23, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
53f4487 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 23, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
245d957 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr pushed a commit to billywr/buildkit that referenced this issue Oct 23, 2024
@tonistiigi @billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
8e5c34f 
…dows.

Partially addressing moby#4485
Signed-off-by: Billy Owire <billyowire95@gmail.com>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Oct 31, 2024
@profnandaa
tests: client: set up for wcow integration tests
dfe57c3 
Make some minor modification to allow running integration
tests for `./client`.

Added tests for `testExportedImageLabels` as a sample.

Ref: moby#4485

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@profnandaa profnandaa mentioned this issue Oct 31, 2024
Merged
billywr added a commit to billywr/buildkit that referenced this issue Nov 4, 2024
@billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
a0fb747 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
@billywr billywr mentioned this issue Nov 4, 2024
Draft
billywr added a commit to billywr/buildkit that referenced this issue Nov 4, 2024
@billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
3dab398 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr added a commit to billywr/buildkit that referenced this issue Nov 4, 2024
@billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
c4b585b 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
billywr added a commit to billywr/buildkit that referenced this issue Nov 4, 2024
@billywr
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Win…
4f883a9 
…dows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@profnandaa profnandaa

Labels
area/windows area/windows-wcow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@profnandaa @tonistiigi