pull: fix content blobs deletion on pull race #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
<3 will give it a try tonight |
Closed
tonistiigi
force-pushed
the
pull-leases
branch
2 times, most recently
from
a4e1fa0
to
d89fe4a
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
Added another commit for long-running time-based lease for manifest and config blobs. This should be rewritten after containerd/containerd#3295 containerd/containerd#3307 with completely removing root labels, that should fix the need for buildkit taking ownership of the namespace and properly clean up canceled pulls. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race where gc cleans up a ref that holds the same blob that is pulled by another ref. Now blobs are kept by a lease during pull, avoiding containerd for cleaning them up. And inserting a blob mapping recreates the root label.
fixes #992 (traces in #991)
@dmcgowan @AkihiroSuda @msg555
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com