binfmt_misc: add support for s390x and ppc64le #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
reviewed
Jul 30, 2019
| @@ -0,0 +1,7 @@ | |||
| .global _start | |||
| .text | |||
| .abiversion 2 | |||
There was a problem hiding this comment.
@AkihiroSuda it took us a while to realize that ppc64 had two ABIs and that we needed this directive.
tiborvass
reviewed
Jul 30, 2019
| @@ -55,6 +61,16 @@ func WarnIfUnsupported(pfs []string) { | |||
| printPlatfromWarning(p, err) | |||
| } | |||
| } | |||
| if p == "linux/ppc64le" { | |||
| if err := ppc64leSupported(); err != nil { | |||
| printPlatfromWarning(p, err) | |||
There was a problem hiding this comment.
i guess this is unrelated to this PR but lovely typo in printPlatfromWarning :D
tiborvass
approved these changes
Jul 31, 2019
|
@tonistiigi Thank you for the enhancement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, these were not automatically detected as I didn't know how good the qemu support is. I tested some basic things like installing packages that seem to work so ok to add them for completeness.
related to docker/buildx#115
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com