ops: fix readwrite mounts it no output #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
reviewed
Aug 9, 2019
solver/llbsolver/ops/exec.go
Outdated
| @@ -606,7 +606,7 @@ func (e *execOp) Exec(ctx context.Context, inputs []solver.Result) ([]solver.Res | |||
| outputs = append(outputs, active) | |||
| mountable = active | |||
| } | |||
| } else if ref == nil { | |||
| } else if m.Dest != pb.RootMount { | |||
There was a problem hiding this comment.
@tonistiigi can you explain this?
There was a problem hiding this comment.
root mount has special handling below
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
readwrite-nooutput
branch
from
02c91a7
to
872bf0b
Compare
tiborvass
approved these changes
Aug 9, 2019
AkihiroSuda
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#922 had a bug that caused readwrite mounts with no outputs to be mounted as readonly
Fix this and add a cap so that new frontends would rather use inefficient caching than mount in a wrong way when talking with old servers.