dockerfile: ignore relative source paths for compatibility #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Aug 9, 2019
tonistiigi
force-pushed
the
relative-ignore
branch
2 times, most recently
from
5f5451a
to
d587f01
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
relative-ignore
branch
from
d587f01
to
f3960ac
Compare
tiborvass
approved these changes
Aug 10, 2019
AkihiroSuda
approved these changes
Aug 10, 2019
This was referenced Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy builder handles relative source paths as they were absolute and so does the copy image. Fileop based implementation took the workdir of source stage into an account. While this behavior can be quite useful it is better to revert to the behavior that is compatible with old builders.
Found when looking at #1123
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com