remotecache: fix inline cache in manifest lists #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
inline-mlist
branch
from
fefcd6a
to
c114e43
Compare
tiborvass
reviewed
Aug 14, 2019
| @@ -110,8 +109,7 @@ func (ci *contentCacheImporter) importInlineCache(ctx context.Context, dt []byte | |||
| return nil, err | |||
| } | |||
|
|
|||
| var mu sync.Mutex | |||
| cc := v1.NewCacheChains() | |||
| var cMap = map[digest.Digest]*v1.CacheChains{} | |||
There was a problem hiding this comment.
Suggested change
| var cMap = map[digest.Digest]*v1.CacheChains{} | |
| var cMap = make(map[digest.Digest]*v1.CacheChains, len(m)) |
tiborvass
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues where inline cache was exported to/imported from manifest lists. Previously the importer could only match one submanifest and exporter didn't export in deterministic order.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com