fix cancellation error not being detected and erroneously cached #2926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the
EOF
errors happening more frequently in the CI.The problem is that when context is canceled in the middle of a fetch stream(grpc stream pushing to containerd), in certain conditions it ends with
EOF
errors instead of cancel error what actually triggered the case. This is deep in containerd libraries so can't be fixed here so instead we need to have more exception cases on checking the errors.The errors are cached both in solver and in the image resolver so I combined them both to use same helper function.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com