integration: set mirrors and entitlements with dockerd worker #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Jan 9, 2023
util/testutil/integration/dockerd.go
Outdated
| return nil, nil, errors.Wrapf(err, "failed to load buildkit config file %s", cfg.ConfigFile) | ||
| } | ||
|
|
||
| var mirrors []string |
There was a problem hiding this comment.
could we set up the entitlements as well
There was a problem hiding this comment.
I see we set:
buildkit/client/client_test.go
Lines 8582 to 8584 in 234dfca
buildkit/client/client_test.go
Lines 8591 to 8593 in 234dfca
I guess it's just for containerd snapshotter right?:
There was a problem hiding this comment.
No, it should work independently of snapshotter
There was a problem hiding this comment.
I guess it's just for containerd snapshotter right?:
Nevermind
tonistiigi
reviewed
Jan 9, 2023
util/testutil/integration/dockerd.go
Outdated
| var mirrors []string | ||
| if reg, ok := bkcfg.Registries["docker.io"]; ok && len(reg.Mirrors) > 0 { | ||
| for _, m := range reg.Mirrors { | ||
| mirrors = append(mirrors, "http://"+m) |
There was a problem hiding this comment.
Ideally the http comes from "localhost" name or "HTTP` property if it is set.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
related to moby/moby#44546 Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
integration-dockerd-mirror
branch
from
5fd2a79
to
489c823
Compare
crazy-max
changed the title
tonistiigi
approved these changes
Jan 9, 2023
neersighted
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up moby/moby#44772 (comment)
Verified on my fork: https://github.com/crazy-max/buildkit/actions/runs/3877830239/jobs/6613351059#step:8:1744
Also update dockerd workflow following changes on moby: moby/moby#44546