Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.11] make tracing socket forward error non-fatal #3483

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

tonistiigi
Copy link
Member

workaround for #3445

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi merged commit 830288a into moby:v0.11 Jan 9, 2023
@AkihiroSuda
Copy link
Member

This doesn't seem merged in the master?

@AkihiroSuda
Copy link
Member

Wondering if we can just place it in the same directory as buildkitd.sock

@tonistiigi
Copy link
Member Author

This doesn't seem merged in the master?

Wondered if we could maybe do something better. I guess theoretically\ we could do some symlink hack? Maybe something simpler.

Wondering if we can just place it in the same directory as buildkitd.sock

Is there a significant difference?

@AkihiroSuda
Copy link
Member

Is there a significant difference?

/run/user/$UID/buildkit/otel-grpc.sock is usually much shorter than $HOME/.local/share/buildkit/otel-grpc.sock

We can probably also omit -grpc

@tonistiigi
Copy link
Member Author

I thought weird jenkins path in #3445 could also affect /run/user/$UID but maybe not. I'm ok with changing this but probably still leave a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants