set osversion in index descriptor from base image #3619
Conversation
| @@ -50,6 +50,23 @@ func (bc *Client) Build(ctx context.Context, fn BuildFunc) (*ResultBuilder, erro | |||
| if tp != nil { | |||
| p = *tp | |||
| } | |||
|
|
|||
| // in certain conditions we allow input platform to be extended from base image | |||
| if p.OS == "windows" && img.OS == p.OS { | |||
There was a problem hiding this comment.
Is there any reason to gate this on Windows?
There was a problem hiding this comment.
You mean in case other OS would also set os.version? I've only seen the field use for windows.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
win-osversion
branch
from
27f3115
to
2844819
Compare
|
We may need a way to tell buildkit to not do this for Windows "host process" images. |
I think we don't need to worry about this for "host process" images. All of the other base images for Windows will have |
As pointed out by @cpuguy83 , when cross-compiling windows images, the manifest descriptors do not contain
OSVersionthat is used on windows. There is currently no way to passOSVersionas containerd has not defined theos/arch/variantserialization for that field, but if base image used by the build hasOSVersiondefined we can just use that one. In image configOSVersionwas already set before by the base image.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com