Fix buildkitd panic when frontend input is nil. #3659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See integ test case for repro, it causes a server-side panic.
Probably a bunch of possible fixes on different levels but opted for the "lowest-level" one by handling this case in
NewDefinitionOp
for now; reduces what was a panic to anerr
return there. Let me know if it's preferable to handle this elsewhere and makeNewDefinitionOp
returnnil, nil
in this case or something like that @tonistiigi