llb: Allow DefinitionOp to track sources #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
tonistiigi
approved these changes
Mar 2, 2023
|
@ktock I think we should cherry-pick this, right? |
Yes, I'll work on that after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently source information stored in DefinitionOp isn't propagated to the vertices available from
DefinitionOp.Inputs(). This commit changes this and makes the source information available in the input vertices as well. This would be useful for inspecting/debugging each vertex in the LLB with keeping track the source location.