buildkitd: add grpc reflection #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets you run: ``` docker run -d --rm --privileged -p 1234:1234 moby/buildkit:local --addr tcp://0.0.0.0:1234 grpcurl -plaintext localhost:1234 list ``` to determine what APIs a grpc server supports. Signed-off-by: Nick Santos <nick.santos@docker.com>
|
@AkihiroSuda @sipsma Any opinions about this one? |
AkihiroSuda
approved these changes
Apr 14, 2023
sipsma
approved these changes
Apr 14, 2023
jedevc
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you run:
to determine what APIs a grpc server supports.
https://github.com/grpc/grpc-go/blob/5a50b970ccaddcd811b4a0da8e56fe1a2492f7da/Documentation/server-reflection-tutorial.md
I find this makes it slightly easier to check if grpc servers are starting up and responding ok. But if you think it's not worth the additional code, it's not a big deal either way.