Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: smoke tests for binaries #4357

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 20, 2023

follow-up #4356 (comment)

Our pipeline run tests regardless if binaries are broken. This adds smoke test to built binaries (runc, buildctl, buildkitd) and also makes test job depends on binaries one so we avoid unnecessary build queues.

Dockerfile Outdated Show resolved Hide resolved
@tonistiigi
Copy link
Member

tonistiigi commented Oct 20, 2023

So this is to test possible cross-compilation errors? Did we hit any of such errors (not clear about conditions in #4356 (comment)) ?

If this is desired then why not just check the binary after building it? Where we currently run xx-verify.

@crazy-max
Copy link
Member Author

So this is to test possible cross-compilation errors? Did we hit any of such errors (not clear about conditions in #4356 (comment)) ?

Yes for cross-comp as well, we got an issue when running validate-docs target and integration tests as well https://github.com/moby/buildkit/actions/runs/6586246066/job/17894326770?pr=4356#step:8:12727

0.094 + buildctl --version
0.106 error: cannot merge resource due to conflicting Schema URL
0.094 + buildkitd --version
0.106 error: cannot merge resource due to conflicting Schema URL

So I think before running any tests we should make sure binaries are not broken.

If this is desired then why not just check the binary after building it? Where we currently run xx-verify.

Yes it would better in this stage, I will make some changes.

@tonistiigi
Copy link
Member

0.094 + buildctl --version
0.106 error: cannot merge resource due to conflicting Schema URL

But this would show up in integration tests (unless cross-comp only). Is this to fail before running any test suites for this specific case.

@crazy-max
Copy link
Member Author

crazy-max commented Oct 20, 2023

0.094 + buildctl --version
0.106 error: cannot merge resource due to conflicting Schema URL

But this would show up in integration tests (unless cross-comp only). Is this to fail before running any test suites for this specific case.

Yes the idea is to avoid running tests if binaries are broken so we avoid unnecessary build queues.

@crazy-max crazy-max force-pushed the binaries-smoketest branch 4 times, most recently from a429d99 to 55b1296 Compare October 23, 2023 14:38
Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This will ensure binaries are not borken before going any further
in the pipeline.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 4abc18c into moby:master Nov 9, 2023
57 checks passed
@crazy-max crazy-max deleted the binaries-smoketest branch November 9, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants