-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile: smoke tests for binaries #4357
Conversation
So this is to test possible cross-compilation errors? Did we hit any of such errors (not clear about conditions in #4356 (comment)) ? If this is desired then why not just check the binary after building it? Where we currently run xx-verify. |
Yes for cross-comp as well, we got an issue when running
So I think before running any tests we should make sure binaries are not broken.
Yes it would better in this stage, I will make some changes. |
But this would show up in integration tests (unless cross-comp only). Is this to fail before running any test suites for this specific case. |
22822dd
to
3dce802
Compare
Yes the idea is to avoid running tests if binaries are broken so we avoid unnecessary build queues. |
a429d99
to
55b1296
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This will ensure binaries are not borken before going any further in the pipeline. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
55b1296
to
4a51fc1
Compare
follow-up #4356 (comment)
Our pipeline run tests regardless if binaries are broken. This adds smoke test to built binaries (runc, buildctl, buildkitd) and also makes test job depends on binaries one so we avoid unnecessary build queues.