-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more validations for nil values #4601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit ef536af15b2d351b8f0459022decc2a4955b1cb2)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit d293ec3208f87fefab7a1caadffa3f3f50604796)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 432ece72ae124ce8a29ced6854a08206f09f3a73)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 4e2569e796aae398648082689d70ca1d4f4f74a8)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 838635998dcae34bbde59e3eab129ab85bd37bef)
AkihiroSuda
approved these changes
Jan 31, 2024
cpuguy83
approved these changes
Jan 31, 2024
GHA export failed due to timeout. |
coryb
added a commit
to coryb/hlb
that referenced
this pull request
May 17, 2024
Related buildkit change: moby/buildkit#4601
pn-santos
added a commit
to pn-santos/oci-build-task
that referenced
this pull request
Oct 31, 2024
moby/buildkit#4601 added additional validation that causes the export of images generated with random.Image to fail so manually set OS and Architecture
pn-santos
added a commit
to pn-santos/oci-build-task
that referenced
this pull request
Oct 31, 2024
moby/buildkit#4601 added additional validation that causes the export of images generated with random.Image to fail so manually set OS and Architecture Signed-off-by: Pedro Nuno Santos <pedro.santos@yoti.com>
pn-santos
added a commit
to pn-santos/oci-build-task
that referenced
this pull request
Oct 31, 2024
moby/buildkit#4601 added additional validation that causes the export of images generated with random.Image to fail so manually set OS and Architecture Signed-off-by: Pedro Nuno Santos <pedro.santos@yoti.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in fix for GHSA-9p26-698r-w4hx
All but two of the changes have no security impact, only for consistency.
@cpuguy83