buildd: graceful shutdown on termination signals #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jul 3, 2017
util/appcontext/appcontext.go
Outdated
| "golang.org/x/sys/unix" | ||
| ) | ||
|
|
||
| // appcontext is a static context that reacts to termination signals of the |
There was a problem hiding this comment.
Where is appcontext (or appContext) now?
There was a problem hiding this comment.
This comment is supposed to be generally about the package. I'll move it to the Context() function.
AkihiroSuda
reviewed
Jul 3, 2017
util/appcontext/appcontext.go
Outdated
| @@ -29,6 +33,7 @@ func appContext() context.Context { | |||
| cancel() | |||
| retries++ | |||
| if retries >= exitLimit { | |||
| logrus.Errorf("forcing shutdown") | |||
There was a problem hiding this comment.
how about got %d SIGTERM/SIGINTs, forcing shutdown?
AkihiroSuda
reviewed
Jul 3, 2017
vendor.conf
Outdated
| @@ -20,7 +20,7 @@ github.com/opencontainers/runc 429a5387123625040bacfbb60d96b1cbd02293ab | |||
| github.com/Microsoft/go-winio v0.4.1 | |||
| github.com/containerd/fifo 69b99525e472735860a5269b75af1970142b3062 | |||
| github.com/opencontainers/runtime-spec 198f23f827eea397d4331d7eb048d9d4c7ff7bee | |||
| github.com/containerd/go-runc 5d38580d03f4fbf2f09b2b0065deeeaf8d21aac2 | |||
| github.com/containerd/go-runc df573a0e124617148f49720e1447061131675694 git://github.com/tonistiigi/go-runc.git | |||
There was a problem hiding this comment.
nit: https:// seems preferred over git:// on github: https://stackoverflow.com/questions/19317264/does-github-support-git-protocol-for-pull
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
graceful-shutdown
branch
from
1b093b1
to
dd4c575
Compare
|
@AkihiroSuda Thanks for the review. Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently shutting down buildd would potentially leak mounts and breaks the output of running clients. This update gracefully shuts down all current handlers before shutting down the process.
based on #49 (only last commit is new)includes fix for
go-runccontainerd/go-runc#19@AkihiroSuda