Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh bridge #184

Merged
merged 9 commits into from
Jul 18, 2016
Merged

Gh bridge #184

merged 9 commits into from
Jul 18, 2016

Conversation

samoht
Copy link
Member

@samoht samoht commented Jul 18, 2016

No description provided.

(fun () -> Client9p.connect proto address ())
(fun _ -> Lwt.fail_with
"%s is not a valid connect adress. Use 'tcp:hostname:port' or \
'unxi:path'."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: unxi

Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Also, more synchronisation robustness

Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
These are a bit too spammy

Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
@samoht
Copy link
Member Author

samoht commented Jul 18, 2016

I think this is ready to merge! I will try to deploy that tomorrow morning.

@samoht samoht merged commit 7564959 into moby:master Jul 18, 2016
@samoht samoht deleted the gh-bridge branch July 18, 2016 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants