libnetwork cherry-picks for 17.06.0 rc3 #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 9, 2017 18:44
The netlink socket that was used to monitor the L2 miss was never being closed. The watchMiss goroutine spawned was never returning. This was causing goroutine leak in case of createNetwork/destroyNetwork Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 65e0999) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit c2d86ca) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The channel ch.C is never closed. Added the listen of the ch.Done() to guarantee that the goroutine is exiting once the event channel is closed Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 1045cfe) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
On linux systems bump up gc_thresholds so to lower the probability of running with neighbor table overflow issues Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit b23cdc3) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The feature was not getting properly triggered, move it as first operation in the configure Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 9d298aa) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
|
@fcrisciani updated |
|
LGTM |
|
@andrewhsu For 17.06.rc3 we need ae6824e (from #1792) as well. |
Signed-off-by: Santhosh Manohar <santhosh@docker.com> (cherry picked from commit ae6824e) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
|
@sanimej it is in |
|
Thanks @andrewhsu @tiborvass LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks taken from: