Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnetwork cherry-picks for 17.06.0 rc3 #1798

Merged
merged 6 commits into from
Jun 9, 2017
Merged

libnetwork cherry-picks for 17.06.0 rc3 #1798

merged 6 commits into from
Jun 9, 2017

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Jun 9, 2017

Cherry-picks taken from:

Flavio Crisciani added 4 commits June 9, 2017 18:44
The netlink socket that was used to monitor the L2
miss was never being closed. The watchMiss goroutine
spawned was never returning. This was causing goroutine
leak in case of createNetwork/destroyNetwork

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit 65e0999)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit c2d86ca)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The channel ch.C is never closed.
Added the listen of the ch.Done() to guarantee
that the goroutine is exiting once the event channel
is closed

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit 1045cfe)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
On linux systems bump up gc_thresholds so to lower the
probability of running with neighbor table overflow issues

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit b23cdc3)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu
Copy link
Member Author

cc @mavenugo @tiborvass

@fcrisciani
Copy link

#1789 needs also #1795 to work properly

The feature was not getting properly triggered, move it as
first operation in the configure

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit 9d298aa)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu
Copy link
Member Author

@fcrisciani updated

@fcrisciani
Copy link

LGTM
Thanks @andrewhsu

@sanimej
Copy link

sanimej commented Jun 9, 2017

@andrewhsu For 17.06.rc3 we need ae6824e (from #1792) as well.

Signed-off-by: Santhosh Manohar <santhosh@docker.com>
(cherry picked from commit ae6824e)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu
Copy link
Member Author

@sanimej it is in

@mavenugo
Copy link
Contributor

mavenugo commented Jun 9, 2017

Thanks @andrewhsu @tiborvass LGTM.

@mavenugo mavenugo merged commit 4118461 into moby:bump_17.06.0 Jun 9, 2017
@andrewhsu andrewhsu deleted the rc3 branch June 9, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants