Bridge driver to support multiple networks #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return d.network, nil | ||
|
|
||
| if id == "" { | ||
| return nil, types.BadRequestErrorf("Invalid network id: %s", id) |
There was a problem hiding this comment.
Make all error strings start with lower case in this PR
|
Ping @mrjana. Thanks for your comments. Took care of them. Please take a look when you get a chance. Also, given multiple network support, automated and enlarged system provided pool of networks in bridge.go. |
| n, ok := d.networks[nid] | ||
| if !ok { | ||
| d.Unlock() | ||
| return types.NotFoundErrorf("Network %s does not exist", nid) |
There was a problem hiding this comment.
You still have strings starting with upper case
|
ping @mrjana . Pls take a look. |
|
LGTM |
|
LGTM. I think this has some level of dependency with #199 and hence will like to get that merged first followed by this PR. |
|
@aboch needs a rebase |
Signed-off-by: Alessandro Boch <aboch@docker.com>
|
thanks @aboch . |
mavenugo
added a commit
that referenced
this pull request
May 24, 2015
Bridge driver to support multiple networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Boch aboch@docker.com