Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd integration: image save/load should produce a JSON stream and image events #43910

Open
thaJeztah opened this issue Aug 4, 2022 · 1 comment · Fixed by #45259
Open
Labels
area/images containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@thaJeztah
Copy link
Member

Description

The existing (non-containerd) implementation writes to a progress stream when loading images; this is currently missing in the containerd implementation; e.g.;

outStream.Write([]byte(fmt.Sprintf("Loaded image: %s\n", reference.FamiliarString(ref))))

outStream.Write([]byte(imageIDsStr))

In addition, the existing implementation generates "image load" and "image save" events;

l.loggerImgEvent.LogImageEvent(imgID.String(), imgID.String(), "load")

s.tarexporter.loggerImgEvent.LogImageEvent(id.String(), id.String(), "save")

@thaJeztah thaJeztah added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/images containerd-integration Issues and PRs related to containerd integration labels Aug 4, 2022
@vvoland
Copy link
Contributor

vvoland commented Sep 22, 2023

Reopening this one as this was only partially addressed.
Image events are produced, but JSON stream with progress is still missing.

@vvoland vvoland reopened this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/images containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants