Fix logs, so now, old and followed logs has same format without [] #10424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, sorry for that :) |
|
can you please make sure there are no examples in the docs that might also change? |
|
@SvenDowideit Yup, okay. |
|
Hah, pretty strange :) seems like Fixed format is not so Fixed |
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
|
ping @jfrazelle |
| @@ -45,23 +45,23 @@ After running docker events a container 786d698004576 is started and stopped | |||
| (The container name has been shortened in the output below): | |||
There was a problem hiding this comment.
If you're going to change the container ID to long form, can you please remove the above?
There was a problem hiding this comment.
Oh, of course :) It's not me, seems like was changed in code at some time.
Or seems like I got it wrong, I'll shorten them back :/
Signed-off-by: Alexandr Morozov <lk4d4@docker.com>
|
@SvenDowideit Fixed |
|
Docs LGTM |
|
LGTM |
Merged
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Feb 6, 2015
Fix logs, so now, old and followed logs has same format without []
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this shows us how often this feature used :)