integ-cli: remove bash dependency from TestSaveDirectoryPermissions #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new `runCommandPipelineWithOutput` helper to remove bash dependency required for piping in `TestSaveDirectoryPermissions`. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
Seems legit 👍 Is there a reason why we shell out and then verify a directory on-disk instead of using |
|
@tianon coz thats what people use when they untar? :P idk, i'm fine either way. LGTM |
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Feb 25, 2015
…ryPermissions-fix integ-cli: remove bash dependency from TestSaveDirectoryPermissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
runCommandPipelineWithOutputhelper toremove bash dependency required for piping in
TestSaveDirectoryPermissions.It wasn't working first time I tried it (test was getting stuck
indefinitely) magically works now.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @jfrazelle @tianon @duglin @LK4D4