Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poule.yml #28143

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Add poule.yml #28143

merged 1 commit into from
Nov 8, 2016

Conversation

icecrime
Copy link
Contributor

@icecrime icecrime commented Nov 8, 2016

Add configuration for poule to manage GitHub automations.

@aluzzardi
Copy link
Member

LGTM 🐔

platform/desktop: [ "docker for mac", "docker for windows" ],
platform/freebsd: [ "freebsd" ],
platform/windows: [ "nanoserver", "windowsservercore", "windows server" ],
}
Copy link
Member

@AkihiroSuda AkihiroSuda Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding more:

area/testing: [ "FAIL: "],
area/plugins: [ "plugin"],
area/kernel: ["Kernel panic - "],
kind/bug: ["panic :"],
platform/arm: ["arm"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For plugins I already have:

    area/plugins: [ "docker plugin" ],

They all make sense, but I'm afraid of adding more until we can see these in effect 😉 Right now poule is not yet deployed, I intend to do it tomorrow first thing and see how it goes from there!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we might need to rethink how matching is done here: I'm using these as regular expression against the lowercase title and body of issues. Something like "arm" is probably too likely to match because of this 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of incorrect matches; do we have something to prevent Poule from adding the incorrect match again after manually correcting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaJeztah No 😢 It will do it again if the issue is edited, or closed/reopened.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icecrime no worries, i'll open an issue for future enhancements

Add configuration for `poule` (https://github.com/icecrime/poule) to
manage GitHub automations.

Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐔

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants