-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poule.yml #28143
Merged
Merged
Add poule.yml #28143
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
# Add a "status/0-triage" to every newly opened pull request. | ||
- triggers: | ||
pull_request: [ opened ] | ||
operations: | ||
- type: label | ||
settings: { | ||
patterns: { | ||
status/0-triage: [ ".*" ], | ||
} | ||
} | ||
|
||
# For every newly created or modified issue, assign label based on matching regexp using the `label` | ||
# operation, as well as an Engine-specific version label using `version-label`. | ||
- triggers: | ||
issues: [ edited, opened, reopened ] | ||
operations: | ||
- type: label | ||
settings: { | ||
patterns: { | ||
area/builder: [ "dockerfile", "docker build" ], | ||
area/distribution: [ "docker login", "docker logout", "docker pull", "docker push", "docker search" ], | ||
area/plugins: [ "docker plugin" ], | ||
area/networking: [ "docker network", "ipvs", "vxlan" ], | ||
area/runtime: [ "oci runtime error" ], | ||
area/security/trust: [ "docker_content_trust" ], | ||
area/swarm: [ "docker node", "docker service", "docker swarm" ], | ||
platform/desktop: [ "docker for mac", "docker for windows" ], | ||
platform/freebsd: [ "freebsd" ], | ||
platform/windows: [ "nanoserver", "windowsservercore", "windows server" ], | ||
} | ||
} | ||
- type: version-label | ||
|
||
# When a pull request is closed, attach it to the currently active milestone. | ||
- triggers: | ||
pull_request: [ closed ] | ||
operations: | ||
- type: version-milestone | ||
|
||
# Labeling a PR with `rebuild/<configuration>` triggers a rebuild job for the associated | ||
# configuration. The label is automatically removed after the rebuild is initiated. There's no such | ||
# thing as "templating" in this configuration, so we need one operation for each type of | ||
# configuration that can be triggered. | ||
- triggers: | ||
pull_request: [ labeled ] | ||
operations: | ||
- type: rebuild | ||
settings: { | ||
configurations: [ arm ], | ||
label: "rebuild/arm", | ||
} | ||
- type: rebuild | ||
settings: { | ||
configurations: [ experimental ], | ||
label: "rebuild/experimental", | ||
} | ||
- type: rebuild | ||
settings: { | ||
configurations: [ janky ], | ||
label: "rebuild/janky", | ||
} | ||
- type: rebuild | ||
settings: { | ||
configurations: [ userns ], | ||
label: "rebuild/userns", | ||
} | ||
- type: rebuild | ||
settings: { | ||
configurations: [ vendor ], | ||
label: "rebuild/vendor", | ||
} | ||
- type: rebuild | ||
settings: { | ||
configurations: [ win2lin ], | ||
label: "rebuild/win2lin", | ||
} | ||
- type: rebuild | ||
settings: { | ||
configurations: [ windowsRS1 ], | ||
label: "rebuild/windowsRS1", | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about adding more:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For plugins I already have:
They all make sense, but I'm afraid of adding more until we can see these in effect 😉 Right now
poule
is not yet deployed, I intend to do it tomorrow first thing and see how it goes from there!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we might need to rethink how matching is done here: I'm using these as regular expression against the lowercase title and body of issues. Something like
"arm"
is probably too likely to match because of this 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking of incorrect matches; do we have something to prevent Poule from adding the incorrect match again after manually correcting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thaJeztah No 😢 It will do it again if the issue is edited, or closed/reopened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icecrime no worries, i'll open an issue for future enhancements