Label ARM issues through Poule #29644 #29645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows build fails with (unrelated):
@talex5 ? |
|
LGTM 👍 |
|
I really need to automate that, but in the meantime: $ poule validate --repository-config poule.yml
2016/12/21 14:57:51 repository configuration file is valid |
thaJeztah
requested changes
Dec 21, 2016
There was a problem hiding this comment.
could you squash your commits? If you need information on how to do that; here's some information https://docs.docker.com/opensource/workflow/work-issue/#/pull-and-rebase-frequently
LGTM otherwise, thanks!!
|
I didn't know how to do that.. I think it's squashed now? @thaJeztah |
GordonTheTurtle
added
dco/no
Signed-off-by: Alex <alexellis2@gmail.com>
|
Yup, that worked! |
|
Seems very prone to false-positive.. #29655 (comment) gets labeled as |
|
opened #29656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex alexellis2@gmail.com
- What I did
Label ARM issues in Github through poule (Gordon the turtle bot)
Reference bug #29644
Label ARM issues with platform/arm.
- How I did it
Edited Pole.yml file from @icecrime
- How to verify it
Run https://github.com/icecrime/poule against docker/docker (I assume this is done through web hooks which I don't have access for)
- Description for the changelog
Label ARM issues in Github through poule (Gordon the turtle bot)
- A picture of a cute animal (not mandatory but encouraged)