Prune named but untagged images if danglingOnly=true #30330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
requested changes
Jan 23, 2017
| continue | ||
| for _, ref := range refs { | ||
| if _, ok := ref.(reference.NamedTagged); ok { | ||
| repoTagsCount++ |
There was a problem hiding this comment.
Can just be a boolean and break can't it?
| // Not a dangling image | ||
| continue | ||
| } | ||
| if !danglingOnly { |
There was a problem hiding this comment.
Can we simplify this a bit?
Seems like we could do something like
shouldDelete := !danglingOnly
if !shouldDelete {
for _, ref := range refs {
if _, ok := ref.(reference.NamedTagged); ok {
shouldDelete = true
break
}
}
if shouldDelete {
// delete all the things
}
}Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
prune-named-untagged
branch
from
43e4060
to
044fa10
Compare
|
@cpuguy83 have a look at this version, it's indeed cleaner, thanks. |
cpuguy83
reviewed
Jan 23, 2017
| continue | ||
| shouldDelete := !danglingOnly | ||
| if !shouldDelete { | ||
| hasTag := false |
There was a problem hiding this comment.
This is really an extra variable since you can set shouldDelete in the loop below.
There was a problem hiding this comment.
shouldDelete needs to stay false in that case. I only want to set it to true if there's no NamedTagged. If I were to set to true here it would delete all images.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
--
Closes #30307