Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bash completion for docker service logs #30510

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Add bash completion for docker service logs #30510

merged 1 commit into from
Jan 31, 2017

Conversation

albers
Copy link
Member

@albers albers commented Jan 27, 2017

Sorry, missed this one: #28089.
Please schedule for 1.13.1.
Ping @sdurrheimer for zsh completion

@AkihiroSuda
Copy link
Member

This is not docker swarm logs 😄
Please modify the commit of the title?

@albers albers changed the title Add bash completion for docker swarm logs Add bash completion for docker service logs Jan 30, 2017
@albers
Add bash completion for docker service logs
1052315 
Signed-off-by: Harald Albers <github@albersweb.de>
@albers
Copy link
Member Author

albers commented Jan 30, 2017

@AkihiroSuda 😳. Thanks for catching this.
Title and commit message are correct now.

@LK4D4
Copy link
Contributor

LK4D4 commented Jan 30, 2017

LGTM

vdemeester
vdemeester approved these changes Jan 31, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester added this to the 1.13.1 milestone Jan 31, 2017
@vdemeester vdemeester merged commit b61fe84 into moby:master Jan 31, 2017
@vieux vieux mentioned this pull request Jan 31, 2017
Merged
@albers albers deleted the completion-swarm-logs branch February 1, 2017 08:07
@albers albers mentioned this pull request Feb 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
kind/experimental process/cherry-picked status/2-code-review
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.
6 participants
@albers @AkihiroSuda @LK4D4 @vdemeester @vieux @GordonTheTurtle