Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not ignore "volume in use" errors when force-delete #31450

Merged
merged 1 commit into from
Mar 6, 2017

Commits on Mar 1, 2017

  1. do not ignore "volume in use" errors when force-delete

    When using `docker volume rm -f`, all errors were ignored,
    and volumes where Purged, even if they were still in
    use by a container.
    
    As a result, repeated calls to `docker volume rm -f`
    actually removed the volume.
    
    The `-f` option was implemented to ignore errors
    in case a volume was already removed out-of-band
    by a volume driver plugin.
    
    This patch changes the remove function to not
    ignore "volume in use" errors if `-f` is used.
    Other errors are still ignored as before.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    9d521a4 View commit details
    Browse the repository at this point in the history