-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Golang to 1.12.1 #38404
Bump Golang to 1.12.1 #38404
Conversation
🚨 🚨 🚨 That doesn't look good. Tons of failures (and looking legitimate) 🚨 🚨 🚨 breakout errors on Linux
37 (!) nasty failures on Windows RS1, including a couple of panics
38 (!) failures on Windows RS5, including a couple of panics
|
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #38404 +/- ##
=========================================
Coverage ? 36.46%
=========================================
Files ? 613
Lines ? 45836
Branches ? 0
=========================================
Hits ? 16715
Misses ? 26841
Partials ? 2280 |
Breakout errors seem to be legit (this is just test output, it was always there AFAIR). Linux failure in Many of the failures on Windows are caused by inability to create files (to be investigated), and those panics are due to the lack of checks in the test case; created #38411 |
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby/moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Upstream-commit: 7e7ff2a033abf87438efe472b5b4c823be09ad48 Component: engine
Go 1.12 beta2 appears to be out at https://golang.org/dl/ (no announce yet) meaning that issue golang/go#29372 should be resolved. Another thing I noticed is
.. and similar error in a few other places. Will send a PR soon |
c43d594
to
9cde941
Compare
For now, set |
Oh, erm.. forgot about this one;
|
61e06c9
to
a29eb3f
Compare
This comment has been minimized.
This comment has been minimized.
8d5c56e
to
47f43fb
Compare
Setting The culprit, for some reason, is A workaround is to remove Still, it makes sense to set more proper location for GOCACHE as by default it takes $HOME as a prefix, and $HOME is set to XXXX/bundles/test-integration/fake-HOME/. Thus the patch that should fix the issue: kolyshkin@3c24f96 (feel free to add to this PR) |
This comment has been minimized.
This comment has been minimized.
Don't attribute to reason what could just as likely be pure ignorance 🤣 |
Go 1.12.1 was released; waiting for docker-library/official-images#5550 to be merged, and images to appear on Docker Hub |
Also removed the `-stretch` suffix, because Debian Stretch is the default base-image now, so there should be no need to keep the suffix Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
06508bd
to
db22517
Compare
And Windows is green! Now waiting for Power and Z, as those images were not yet on Docker Hub; looks like they're now, so 🤞 |
and... all green now!! ping @jhowardmsft @kolyshkin @cpuguy83 PTAL 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 7e7ff2a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby/moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 7e7ff2a033abf87438efe472b5b4c823be09ad48) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 8c60be3be4048b08a154df274afaff05b7bfba14 Component: engine
Follow-up to #38402 and #38403
Opening this PR to updates to Golang 1.12, and see if there are regressions / issues
flaky test failing (#38720)resolved by #38737Go regression golang/go#30283resolved by golang/go@2d34740Go regression golang/go#30307resolved by golang/go@c55fb33Go regression golang/go#30307resolved by golang/go@c55fb33 (same as above)