Bump Golang to 1.12.1 #38404
Merged
Bump Golang to 1.12.1 #38404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 🚨 🚨 That doesn't look good. Tons of failures (and looking legitimate) 🚨 🚨 🚨 breakout errors on Linux37 (!) nasty failures on Windows RS1, including a couple of panics38 (!) failures on Windows RS5, including a couple of panics |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #38404 +/- ##
=========================================
Coverage ? 36.46%
=========================================
Files ? 613
Lines ? 45836
Branches ? 0
=========================================
Hits ? 16715
Misses ? 26841
Partials ? 2280 |
|
Breakout errors seem to be legit (this is just test output, it was always there AFAIR). Linux failure in Many of the failures on Windows are caused by inability to create files (to be investigated), and those panics are due to the lack of checks in the test case; created #38411 |
kolyshkin
added a commit
to kolyshkin/moby
that referenced
this pull request
Dec 21, 2018
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Dec 21, 2018
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby/moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Upstream-commit: 7e7ff2a033abf87438efe472b5b4c823be09ad48 Component: engine
|
Go 1.12 beta2 appears to be out at https://golang.org/dl/ (no announce yet) meaning that issue golang/go#29372 should be resolved. Another thing I noticed is
.. and similar error in a few other places. Will send a PR soon |
thaJeztah
changed the title
thaJeztah
force-pushed
the
bump_golang_1.12
branch
from
c43d594
to
9cde941
Compare
|
For now, set |
|
Oh, erm.. forgot about this one;
|
thaJeztah
force-pushed
the
bump_golang_1.12
branch
from
61e06c9
to
a29eb3f
Compare
This comment has been minimized.
This comment has been minimized.
thaJeztah
force-pushed
the
bump_golang_1.12
branch
2 times, most recently
from
8d5c56e
to
47f43fb
Compare
|
Setting The culprit, for some reason, is A workaround is to remove Still, it makes sense to set more proper location for GOCACHE as by default it takes $HOME as a prefix, and $HOME is set to XXXX/bundles/test-integration/fake-HOME/. Thus the patch that should fix the issue: kolyshkin@3c24f96 (feel free to add to this PR) |
This comment has been minimized.
This comment has been minimized.
|
Don't attribute to reason what could just as likely be pure ignorance 🤣 |
Merged
|
Go 1.12.1 was released; waiting for docker-library/official-images#5550 to be merged, and images to appear on Docker Hub |
Also removed the `-stretch` suffix, because Debian Stretch is the default base-image now, so there should be no need to keep the suffix Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_golang_1.12
branch
from
06508bd
to
db22517
Compare
thaJeztah
added
status/2-code-review
impact/changelog
and removed
status/0-triage
labels
|
And Windows is green! Now waiting for Power and Z, as those images were not yet on Docker Hub; looks like they're now, so 🤞 |
|
and... all green now!! ping @jhowardmsft @kolyshkin @cpuguy83 PTAL 🤗 |
adhulipa
pushed a commit
to adhulipa/docker
that referenced
this pull request
Apr 11, 2019
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Oct 23, 2019
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 7e7ff2a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 28, 2019
A lack of check in the test code can lead to a panic due to `len(ids)` being `0`. Avoid the panic by adding appropriate checks. Note `Assert()` should be used rather than `Check()` as if it fails we should not proceed with the test. Originally found in moby/moby#38404. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 7e7ff2a033abf87438efe472b5b4c823be09ad48) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 8c60be3be4048b08a154df274afaff05b7bfba14 Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #38402 and #38403
Opening this PR to updates to Golang 1.12, and see if there are regressions / issues
flaky test failing (#38720)resolved by #38737Go regression golang/go#30283resolved by golang/go@2d34740Go regression golang/go#30307resolved by golang/go@c55fb33Go regression golang/go#30307resolved by golang/go@c55fb33 (same as above)