-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.12 #837
go 1.12 #837
Conversation
Let's give it a couple of days to figure out if the containerd panic in power is cleared in latest version. |
CI is timing out on PowerPC, but it was confirmed to be fixed (there's a regression on Windows though, but I guess that's not yet important in this repository); containerd/containerd#2896 |
@thaJeztah Is docker 19.03 going to ship with 1.12 ? |
@tonistiigi we'll have to wait for Go 1.12.1 to be released to get the fix for Windows (see moby/moby#38404 (comment)) |
@AkihiroSuda moby/moby#38404 is merged. Update this to 1.12.1 as well when you have time. |
Do we want to pin to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkihiroSuda Ah, yes. This should be good. Let's just wait for CI to pass again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp