Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.12 #837

Merged
merged 1 commit into from
Mar 18, 2019
Merged

go 1.12 #837

merged 1 commit into from
Mar 18, 2019

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

@tonistiigi
Copy link
Member

Let's give it a couple of days to figure out if the containerd panic in power is cleared in latest version.

@thaJeztah
Copy link
Member

CI is timing out on PowerPC, but it was confirmed to be fixed (there's a regression on Windows though, but I guess that's not yet important in this repository); containerd/containerd#2896

@tonistiigi
Copy link
Member

@thaJeztah Is docker 19.03 going to ship with 1.12 ?

@thaJeztah
Copy link
Member

@tonistiigi we'll have to wait for Go 1.12.1 to be released to get the fix for Windows (see moby/moby#38404 (comment))

@tonistiigi
Copy link
Member

@AkihiroSuda moby/moby#38404 is merged. Update this to 1.12.1 as well when you have time.

@AkihiroSuda
Copy link
Member Author

golang:1.12[-alpine] points to 1.12.1 now.

Do we want to pin to golang:1.12.1[-alpine] explicitly?

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkihiroSuda Ah, yes. This should be good. Let's just wait for CI to pass again.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi tonistiigi merged commit 6bc2b82 into moby:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants