Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry.loginV2(): minor cleanup #41605

Merged
merged 1 commit into from
Nov 6, 2020
Merged

registry.loginV2(): minor cleanup #41605

merged 1 commit into from
Nov 6, 2020

Conversation

thaJeztah
Copy link
Member

just some minor cleaning up; construct the endpoint-path once instead of twice, and grouping all variable declarations at the start.

@thaJeztah
registry.loginV2(): minor cleanup
ac84f1b 
just some minor cleaning up; construct the endpoint-path once
instead of twice, and grouping all variable declarations at the
start.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Failing on a flaky test; tracked through #38521. However, usually it was on Windows (which was disabled in #40117), but now failed on Linux 🤔

=== RUN   TestDockerSuite/TestStartReturnCorrectExitCode
    --- FAIL: TestDockerSuite/TestStartReturnCorrectExitCode (1.04s)
        docker_cli_start_test.go:209: assertion failed: expected an error, got nil

@thaJeztah thaJeztah mentioned this pull request Oct 30, 2020
Open
tianon
tianon approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 3b14605 into moby:master Nov 6, 2020
@thaJeztah thaJeztah deleted the login2_cleanup branch November 6, 2020 07:53
@thaJeztah thaJeztah added this to the 20.10.0 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/distribution kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @tianon @nemith @AkihiroSuda