Make sure stream.Read() unblocks for close + reset #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that stream.Read() always unblocks after a stream.Close() followed by a stream.Reset(). Even if the stream is considered finished (which happens when you call stream.Close()), we need to still call stream.closeRemoteChannels() when stream.Reset() is called, regardless of the value of stream.finished. This ensures that stream.closeChan is closed, which unblocks readers.
|
@dmcgowan yet another edge case, /sigh. PTAL and let me know what you think. Thanks!!! |
|
Too bad more people aren't using this library so they can take advantage of all this hardening you are doing 😄 Curious if you guys are planning on switching to something HTTP2 based like gRPC? I need to play around with it more to see what I could recommend as alternatives while getting the same easy stream access. LGTM |
dmcgowan
added a commit
that referenced
this pull request
Mar 10, 2016
…-reset Make sure stream.Read() unblocks for close + reset
|
We are hoping to switch to HTTP/2 once we move to go 1.6. I did a POC in Kubernetes that hacked it in for exec/attach/port-forward using a prerelease version of 1.6. It had some issues and was quite rough about the edges, but I'm optimistic I'll be able to make it work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that stream.Read() always unblocks after a stream.Close() followed by a stream.Reset().
Even if the stream is considered finished (which happens when you call stream.Close()), we need to
still call stream.closeRemoteChannels() when stream.Reset() is called, regardless of the value of
stream.finished. This ensures that stream.closeChan is closed, which unblocks readers.