-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ca] Include a signing profile for cross-signing CA certs externally #2212
[ca] Include a signing profile for cross-signing CA certs externally #2212
Conversation
57f5a4b
to
ca6214e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
- Coverage 60.24% 60.22% -0.02%
==========================================
Files 124 124
Lines 20114 20115 +1
==========================================
- Hits 12117 12114 -3
- Misses 6639 6643 +4
Partials 1358 1358 |
Actually, this would be useful for folks running the default CFSSL server (such as me when I'm testing) and so would probably be good to include in 17.06. In our sample external signing server, we run our own TLS server and write our own HTTP handler, which unmarshalls the signing request directly from JSON: https://github.com/docker/swarmkit/blob/master/ca/testutils/externalutils.go#L200 In the CFSSL server, the request is first unmarshalled to an intermediary object, which does not support the I'll submit a PR upstream to CFSSL to support the |
…quest to external CAs. This way it will be easier for them to implement extra policies. Signed-off-by: Ying Li <ying.li@docker.com>
ca6214e
to
8d11a94
Compare
"github.com/docker/swarmkit/ca" | ||
"github.com/pkg/errors" | ||
) | ||
|
||
var crossSignPolicy = config.SigningProfile{ | ||
Usage: []string{"cert sign", "crl sign"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need crl sign
, but there is nothing wrong with including it.
Includes: - moby/swarmkit#2203 - moby/swarmkit#2210 - moby/swarmkit#2212 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
Includes: - moby/swarmkit#2203 - moby/swarmkit#2210 - moby/swarmkit#2212 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
Includes: - moby/swarmkit#2203 - moby/swarmkit#2210 - moby/swarmkit#2212 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
Includes: - moby/swarmkit#2203 - moby/swarmkit#2210 - moby/swarmkit#2212 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
Includes: - moby/swarmkit#2203 - moby/swarmkit#2210 - moby/swarmkit#2212 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
When we make an external CA request to cross-sign a certificate, include a particular signing profile that can be implemented by the external CA.
This way it will be easier for them to implement extra policies.
This is not urgent, but would be good to make this part of the input external CAs that interact with swarm should expect.
cc @diogomonica @aaronlehmann @jlhawn