-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update dependencies for go.etcd.io #3091
Merged
thaJeztah
merged 16 commits into
moby:master
from
thaJeztah:some_end_to_dependency_hell_step1
Nov 23, 2022
Merged
go.mod: update dependencies for go.etcd.io #3091
thaJeztah
merged 16 commits into
moby:master
from
thaJeztah:some_end_to_dependency_hell_step1
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indirect dependency, but updating removes some other dependencies. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's an indirect dependency, but updating other modules will cause it to be updated, so updating it first. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's an indirect dependency, but updating other modules will cause it to be updated, so updating it first. This is an intermediate version, which can be done in isolation. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Intermediate update to keep the diffs small Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's an indirect dependency, but updating other modules will cause it to be updated, so updating it first. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to get rid of the golang.org/x/xerrors dependency Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Now that other dependencies are updated, we can update this one in isolation (yay for circular dependencies). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's an indirect dependency, but updating other modules will cause it to be updated, so updating it first. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's an indirect dependency, but updating other modules will cause it to be updated, so updating it first. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
To match other projects and (upcoming) dependencies. Full diff: https://github.com/prometheus/client_golang/compare/v1.11.0..v1.12.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
go.mod: update dependencies for go.etc.io
go.mod: update dependencies for go.etcd.io
Nov 22, 2022
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Removes various indirect dependencies Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@dperny @corhere @neersighted PTAL (trying to reduce the diff to find where the failure is; looks like in etcd itself). |
corhere
approved these changes
Nov 23, 2022
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start with these dependencies (needed for #3085), so that we can debug the failure with the last commit (etcd itself)