mountinfo: rewrite more tests to use a test-table #82
Conversation
This allows us to more easily add more/other samples, as well as combine the TestParseFedoraMountinfo, TestParseUbuntuMountinfo, TestParseGentooMountinfo, and TestParseFedoraMountinfoFields tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
To me, the first commit definitely make sense (and is something I wanted to do myself but never got around to), the second one kind of make sense (if we have the data, why not use it for testing)? The last commit seems useless. It makes sense in runc, as it was added together with a specific fix, to make sure runc parser can parse multiple cgroup v1 mount hierarchies (rather than one which is usual). Here it doesn't make sense since the parser is generic and doesn't care about how many cgroup v1 mount hierarchies are there. Can we drop the last commit? |
Ah, yes. I initially was looking if it would make sense to have (some of) the cgroups helper in this repository as well (and for that reason, to have test coverage), but currently that's not there, so they don't add much. I'll drop that commit. |
thaJeztah
force-pushed
the
more_test_tables
branch
from
4096e13
to
6089f58
Compare
thaJeztah
changed the title
|
Updated to drop the last commit 👍 |
See individual commits for details