This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Do not use filepath.Join if constructing LinuxKit paths #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rn |
justincormack
force-pushed
the
filepathjoin
branch
from
2229461
to
5f7207c
Compare
|
I think you just want to use |
rn
reviewed
Aug 14, 2017
src/moby/util.go
Outdated
|
|
||
| // we are largely handling Linux paths, so do not want to use filepath.Join() | ||
| func filepathJoin(paths ...string) string { | ||
| return strings.Join(paths, "/") |
There was a problem hiding this comment.
filepath.Join() also does a filepath.Clean(). This may not be relevant here...
|
@ijc oh yes. |
justincormack
force-pushed
the
filepathjoin
branch
2 times, most recently
from
9fd7d03
to
4fd019a
Compare
This will do the wrong thing on Windows, and construct paths with \. fix moby#142 Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
filepathjoin
branch
from
4fd019a
to
4da3c09
Compare
|
Ok, reworked using |
ijc
approved these changes
Aug 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will do the wrong thing on Windows, and construct paths with .
fix #142
Signed-off-by: Justin Cormack justin.cormack@docker.com