This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Rename "output" to "format" #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincormack
force-pushed
the
formats
branch
from
7e06264
to
25ab7fc
Compare
Thank you, yes. It was confusing. Are the README/ |
|
The |
justincormack
changed the title
justincormack
force-pushed
the
formats
branch
from
25ab7fc
to
9033e34
Compare
justincormack
added a commit
to justincormack/linuxkit
that referenced
this pull request
Sep 1, 2017
This is less confusing as there is also an output option to set the file. See moby/tool#146 Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
added a commit
to justincormack/linuxkit
that referenced
this pull request
Sep 1, 2017
This is less confusing as there is also an output option to set the file. See moby/tool#146 Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
formats
branch
from
9033e34
to
5c4435b
Compare
ijc
reviewed
Sep 1, 2017
cmd/moby/build.go
Outdated
| @@ -56,7 +56,7 @@ func getDiskSizeMB(s string) (int, error) { | |||
|
|
|||
| // Process the build arguments and execute build | |||
| func build(args []string) { | |||
| var buildOut outputList | |||
| var buildFormats outputList | |||
There was a problem hiding this comment.
should this PR also s/outputList/formatList?
This was confusing as there is an option to output to a file as well. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
formats
branch
from
5c4435b
to
11b573c
Compare
ijc
approved these changes
Sep 1, 2017
justincormack
added a commit
to justincormack/linuxkit
that referenced
this pull request
Sep 1, 2017
This is less confusing as there is also an output option to set the file. See moby/tool#146 Signed-off-by: Justin Cormack <justin.cormack@docker.com>
ijc
pushed a commit
to linuxkit/kubernetes
that referenced
this pull request
Nov 17, 2017
This is less confusing as there is also an output option to set the file. See moby/tool#146 Signed-off-by: Justin Cormack <justin.cormack@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was confusing as there is an option to output to a file as well.
Signed-off-by: Justin Cormack justin.cormack@docker.com
cc @deitch I think you suggested this...