This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Improvements to Makefile, linting, and circleci.yml #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
improve-the-build
branch
4 times, most recently
from
a1d31f1
to
89d56cb
Compare
Use gometalinter for linting put build artifact in dist/ store artifacts in circleci Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
dnephin
force-pushed
the
improve-the-build
branch
from
89d56cb
to
ec74185
Compare
|
I also notice that this doesn't specify a go version in the circleci config. This should probably test against a specific version of go. I haven't made that change as part of this PR. |
justincormack
approved these changes
Oct 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use gometalinter for linting
// nolint--installinstead of installing each thing separately)Improve the cirlceci config
Makefile improvements
dist/directoryCleanup
vendor/vendor.confincluded some unused packages, apparentlyvndris still broken and doesn't work about these unused packages.Also fix existing lint errors.