This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Add Cgroups to runtime config #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijc
reviewed
Nov 16, 2017
docs/yaml.md
Outdated
| @@ -183,6 +183,7 @@ permissions issues in use. | |||
|
|
|||
| In addition to the parts of the specification above used to generate the OCI spec, there is a `runtime` section in the image specification | |||
| which specifies some actions to take place when the container is being started. | |||
| - `cgroups` takes a list of cgroups that will be created before the container is run. | |||
ijc
approved these changes
Nov 16, 2017
justincormack
force-pushed
the
runtime-cgroups
branch
from
734deb2
to
54d00e2
Compare
This will create the list of cgroups specified Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
runtime-cgroups
branch
from
54d00e2
to
c9bb1ec
Compare
|
Amended as I forgot the schema change. |
|
ok, have the other end of this working now |
justincormack
added a commit
to justincormack/linuxkit
that referenced
this pull request
Nov 17, 2017
Implements moby/tool#181 Design for things like Kubernetes setup that requires some cgroups to exist when the service starts but it is not running in these, other services are, so there would be a race if they are not created in each. Essentially it is just a sugared `mkdir` in all the cgroup dirs. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
rn
pushed a commit
to rn/linuxkit
that referenced
this pull request
Nov 21, 2017
Implements moby/tool#181 Design for things like Kubernetes setup that requires some cgroups to exist when the service starts but it is not running in these, other services are, so there would be a race if they are not created in each. Essentially it is just a sugared `mkdir` in all the cgroup dirs. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create the list of cgroups specified
Signed-off-by: Justin Cormack justin.cormack@docker.com
Note that the implementation is not done yet in linuxkit...