This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Defer dockerRm until we are finished with the contents #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced by moby#191 but somehow did not trigger either for me in local testing or in CI. It did trigger in initial CI of linuxkit/linuxkit#2811 which can be seen at https://linuxkit.datakit.ci/linuxkit/linuxkit/pr/2811?history=1637690296123e9a15307b3a41b290da6e27e7cc The error is: Failed to docker rm container «...»: «...»: aufs: unmount error after retries: «...»: device or resource busy No doubt because we were still holding an open fd while trying to remove the container. Unclear why this didn't repro for me (docker 17.11.0-ce with overlay2) or whatever CI uses. Signed-off-by: Ian Campbell <ijc@docker.com>
|
Might want to consider the result of linuxkit/linuxkit#2811 CI too since I've shoehorned this fix in there too for the time being. |
justincormack
approved these changes
Dec 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by #191 but somehow did not trigger either for me in local
testing or in CI.
It did trigger in initial CI of linuxkit/linuxkit#2811
which can be seen at https://linuxkit.datakit.ci/linuxkit/linuxkit/pr/2811?history=1637690296123e9a15307b3a41b290da6e27e7cc
The error is:
No doubt because we were still holding an open fd while trying to remove the
container.
Unclear why this didn't repro for me (docker 17.11.0-ce with overlay2) or
whatever CI uses.
Signed-off-by: Ian Campbell ijc@docker.com